Add Price and Extended price to Project Bom by whinis · Pull Request #1221 · Part-DB/Part-DB-server

whinis · 2026-02-02T23:48:25Z

This seems to be one of the most requested changes and I also needed this particular feature.
requested in #603 and others in discussion. So this allows one to see the price of each item in the bom if it exists in any way. It currently selects just the first supplier and the first (likely most expensive) unit price for the part.

jbtronics · 2026-02-17T12:55:08Z

Thanks,

The PricedetailHelper has an calculateAvg() price to calculate an average price across all suppliers, it also handles currency conversions correctly.
Also you should use the correct Intl Number Formatter to get the correctly formatted price for users locale. The currency symbol should be included, to mark which currency this is.

Unfortunatley the whole price infrastructure in Part-DB is quite limited and ideally would need some heavy rewrites, with some more powerful functions to make things like this easier...

MayNiklas · 2026-03-13T19:13:43Z

The PricedetailHelper has an calculateAvg() price to calculate an average price across all suppliers, it also handles currency conversions correctly.

Just a random thought:
When calculating the price of a project, I would prefer the price being worse compared to it being too good.
This way, we don't run into the risk of thinking something is cheaper than it actually is.

The complicated thing about pricing: it won't reflect the actual price we bought parts for & sometimes our stock even might contain the same part bought for different prices.

I would love the price estimation to reflect what I'm able to buy the parts now for:
Instead of using the average price, which might result in a price being too good, I would prefer to use the prices of the amounts we actually require to build a fixed amount of units.

Long story short:
I don't know how others think about it, but I would prefer prices to be higher compared tp them being too low.
I would even be fine with PartDB just using the more expensive prices for lower amounts of parts, instead of using the price average.

I know prices in PartDB are complicated!
Of any specific help is required, I would love to help!

whinis · 2026-03-13T19:45:37Z

The PricedetailHelper has an calculateAvg() price to calculate an average price across all suppliers, it also handles currency conversions correctly.

Just a random thought: When calculating the price of a project, I would prefer the price being worse compared to it being too good. This way, we don't run into the risk of thinking something is cheaper than it actually is.

The complicated thing about pricing: it won't reflect the actual price we bought parts for & sometimes our stock even might contain the same part bought for different prices.

I would love the price estimation to reflect what I'm able to buy the parts now for: Instead of using the average price, which might result in a price being too good, I would prefer to use the prices of the amounts we actually require to build a fixed amount of units.

Long story short: I don't know how others think about it, but I would prefer prices to be higher compared tp them being too low. I would even be fine with PartDB just using the more expensive prices for lower amounts of parts, instead of using the price average.

I would love the price estimation to reflect what I'm able to buy the parts now for

Thats what the PR essentially does or theoretically does. I could force it but it currently gets the first price which atleast in my setup tends to be qty 1 price.

MayNiklas · 2026-03-13T19:47:39Z

@whinis I implemented the changes @jbtronics asked for.
Should I share them with you so you can commit them, adding me as a co-author?

MayNiklas · 2026-03-13T19:48:42Z

My previous comment can be ignored - I realised how average price works! :)

MayNiklas · 2026-03-13T20:22:59Z

@whinis If you want to, you can commit my patch integrating the requested changes.
Save the following diff as a file commit.diff.
Then use git am --3way commit.diff.
git am is used to mailbox patches :)

The changes greatly simplify the price calculation!
I have to agree with @jbtronics - this is much nicer!

From 44a9aa16b312f64b83777efd8c369a8ce3805310 Mon Sep 17 00:00:00 2001
From: MayNiklas <info@niklas-steffen.de>
Date: Fri, 13 Mar 2026 21:15:25 +0100
Subject: [PATCH] project prices: use calculateAvg


diff --git a/src/DataTables/ProjectBomEntriesDataTable.php b/src/DataTables/ProjectBomEntriesDataTable.php
index 3acef03f..ec1f5ff4 100644
--- a/src/DataTables/ProjectBomEntriesDataTable.php
+++ b/src/DataTables/ProjectBomEntriesDataTable.php
@@ -39,12 +39,14 @@ use Omines\DataTablesBundle\Column\TextColumn;
 use Omines\DataTablesBundle\DataTable;
 use Omines\DataTablesBundle\DataTableTypeInterface;
 use Symfony\Contracts\Translation\TranslatorInterface;
+use App\Services\Parts\PricedetailHelper;
 use Brick\Math\BigDecimal;
 
 class ProjectBomEntriesDataTable implements DataTableTypeInterface
 {
     public function __construct(protected TranslatorInterface $translator, protected PartDataTableHelper $partDataTableHelper,
-        protected EntityURLGenerator $entityURLGenerator, protected AmountFormatter $amountFormatter)
+        protected EntityURLGenerator $entityURLGenerator, protected AmountFormatter $amountFormatter,
+        protected PricedetailHelper $pricedetailHelper)
     {
     }
 
@@ -183,62 +185,18 @@ class ProjectBomEntriesDataTable implements DataTableTypeInterface
             ->add('price', TextColumn::class, [
                 'label' => 'project.bom.price',
                 'render' => function ($value, ProjectBOMEntry $context) {
-                    // Let's attempt to get the part, if we don't we will just assume zero
-                    $part = $context->getPart();
-                    $price = BigDecimal::zero();
-                    $pricedetails = null;
-                    $order = null;
-                    // Check if we get a part and get the first order if so
-                    // if not see if there is a non-part price set
-                    if($part) {
-                        $order = $context->getPart()->getOrderdetails()->first();
-                    } else if($context->getPrice() !== null) {
-                        $price = $context->getPrice();
-                    }
-
-                    // check if there is an order, if so get the first pricedetail of the order
-                    if($order!==null && $order !== false) {
-                        $pricedetails = $order->getPricedetails()->first();
-                    }
-
-                    // check if there is a pricedetail, if so get the first price
-                    if($pricedetails !== null && $pricedetails !== false) {
-                        $price = $pricedetails->getPrice();
-                    }
+                    $price = $this->getBomEntryUnitPrice($context);
 
-                    // return the price
-                    return  htmlspecialchars(number_format($price->toFloat(),2));
+                    return htmlspecialchars(number_format($price->toFloat(), 2));
                 },
                 'visible' => false,
             ])
             ->add('ext_price', TextColumn::class, [
                 'label' => 'project.bom.ext_price',
                 'render' => function ($value, ProjectBOMEntry $context) {
-                    // Let's attempt to get the part, if we don't we will just assume zero
-                    $part = $context->getPart();
-                    $price = BigDecimal::zero();
-                    $pricedetails = null;
-                    $order = null;
-                    // Check if we get a part and get the first order if so
-                    // if not see if there is a non-part price set
-                    if($part) {
-                        $order = $context->getPart()->getOrderdetails()->first();
-                    } else if($context->getPrice() !== null) {
-                        $price = $context->getPrice();
-                    }
-
-                    // check if there is an order, if so get the first pricedetail of the order
-                    if($order!==null && $order !== false) {
-                        $pricedetails = $order->getPricedetails()->first();
-                    }
+                    $price = $this->getBomEntryUnitPrice($context);
 
-                    // check if there is a pricedetail, if so get the first price
-                    if($pricedetails !== null && $pricedetails !== false) {
-                        $price = $pricedetails->getPrice();
-                    }
-
-                    // return the price
-                    return  htmlspecialchars(number_format($price->toFloat() * $context->getQuantity(),2));
+                    return htmlspecialchars(number_format($price->toFloat() * $context->getQuantity(), 2));
                 },
             ])
 
@@ -268,6 +226,16 @@ class ProjectBomEntriesDataTable implements DataTableTypeInterface
         ]);
     }
 
+    private function getBomEntryUnitPrice(ProjectBOMEntry $entry): BigDecimal
+    {
+        if ($entry->getPart() instanceof Part) {
+            return $this->pricedetailHelper->calculateAvgPrice($entry->getPart(), $entry->getQuantity()) ?? BigDecimal::zero();
+        }
+
+        return $entry->getPrice() ?? BigDecimal::zero();
+    }
+
+
     private function getQuery(QueryBuilder $builder, array $options): void
     {
         $builder->select('bom_entry')

whinis · 2026-03-13T20:35:22Z

@MayNiklas Alright I incorporated that. It does look nicer in this case.

MayNiklas · 2026-03-13T20:54:56Z

@jbtronics this PR should be ready for a re-review :)

MayNiklas · 2026-03-13T21:36:42Z

@jbtronics I just noticed, that pricedetailHelper->calculateAvgPrice does not work as expected for smaller quantities, when quantity < minimum order amount.
In those cases, the function returns NULL, leading to a price of 0,00 being used.
Would it be possible to fix that behaviour? Or does anything speak against it?

MayNiklas

I just added two suggestions I noticed this morning :)

prices should maybe be rounded up, since 0,00€ parts are realistically more 0,01€ stan 0,00€
in cases where getMinOrderAmount > amount, we previously returned NULL. With my suggestion we would continue to work with the minimum ammount that can be ordered.

MayNiklas · 2026-03-14T10:37:28Z

src/DataTables/ProjectBomEntriesDataTable.php

+                    return  htmlspecialchars(number_format($price->toFloat() * $context->getQuantity(),2));
+                },


Suggested change

return htmlspecialchars(number_format($price->toFloat() * $context->getQuantity(),2));

},

return htmlspecialchars(number_format($this->roundUpDisplayedPrice($price)->toFloat(), 2));

},

MayNiklas · 2026-03-14T10:38:16Z

src/DataTables/ProjectBomEntriesDataTable.php

+                    $price = $this->getBomEntryUnitPrice($context);
+
+                    // return the price
+                    return  htmlspecialchars(number_format($price->toFloat(),2));


How about rounding prices up to the full cent?
This might be especially helpful for very cheap parts:
Currently resistors / caps might be shown as 0,00€, even while not being free.

Suggested change

return htmlspecialchars(number_format($price->toFloat(),2));

return htmlspecialchars(number_format($this->roundUpDisplayedPrice($price)->toFloat(), 2));

MayNiklas · 2026-03-14T10:41:52Z

src/DataTables/ProjectBomEntriesDataTable.php

+        if ($entry->getPart() instanceof Part) {
+            return $this->pricedetailHelper->calculateAvgPrice($entry->getPart(), $entry->getQuantity()) ?? BigDecimal::zero();
+        }
+
+        return $entry->getPrice() ?? BigDecimal::zero();


We previously not correctly handled cases with amount < minimum order amount.
This should fix it!

Suggested change

if ($entry->getPart() instanceof Part) {

return $this->pricedetailHelper->calculateAvgPrice($entry->getPart(), $entry->getQuantity()) ?? BigDecimal::zero();

}

return $entry->getPrice() ?? BigDecimal::zero();

if ($entry->getPart() instanceof Part) {

$amount = $entry->getQuantity();

$minOrderAmount = $this->pricedetailHelper->getMinOrderAmount($entry->getPart());

if ($minOrderAmount !== null) {

$amount = max($amount, $minOrderAmount);

}

return $this->pricedetailHelper->calculateAvgPrice($entry->getPart(), $amount) ?? BigDecimal::zero();

}

return $entry->getPrice() ?? BigDecimal::zero();

MayNiklas · 2026-03-14T10:46:08Z

src/DataTables/ProjectBomEntriesDataTable.php

+
+        return $entry->getPrice() ?? BigDecimal::zero();
+    }



I just forgot to add roundUpDisplayedPrice

Suggested change

private function roundUpDisplayedPrice(BigDecimal $price): BigDecimal

{

return $price->toScale(2, RoundingMode::UP);

}

whinis force-pushed the add-bom-price branch 4 times, most recently from 166bcb5 to 35262a2 Compare February 4, 2026 04:08

Added Price and Extended price to project bom table.

fa7cedd

whinis force-pushed the add-bom-price branch from 35262a2 to fa7cedd Compare February 4, 2026 04:22

mkne mentioned this pull request Feb 19, 2026

Show part status in BOM #1256

Closed

Made changes from MayNiklas proposed by jbtronics

d6cf425

MayNiklas reviewed Mar 14, 2026

View reviewed changes

		return htmlspecialchars(number_format($price->toFloat() * $context->getQuantity(),2));
		},

	return htmlspecialchars(number_format($price->toFloat(),2));
	return htmlspecialchars(number_format($this->roundUpDisplayedPrice($price)->toFloat(), 2));

+    private function roundUpDisplayedPrice(BigDecimal $price): BigDecimal
+    {
+        return $price->toScale(2, RoundingMode::UP);
+    }

Uh oh!

Conversation

whinis commented Feb 2, 2026

Uh oh!

jbtronics commented Feb 17, 2026

Uh oh!

MayNiklas commented Mar 13, 2026

Uh oh!

whinis commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MayNiklas commented Mar 13, 2026

Uh oh!

MayNiklas commented Mar 13, 2026

Uh oh!

MayNiklas commented Mar 13, 2026

Uh oh!

whinis commented Mar 13, 2026

Uh oh!

MayNiklas commented Mar 13, 2026

Uh oh!

MayNiklas commented Mar 13, 2026

Uh oh!

MayNiklas left a comment

Choose a reason for hiding this comment

Uh oh!

MayNiklas Mar 14, 2026

Choose a reason for hiding this comment

Uh oh!

MayNiklas Mar 14, 2026

Choose a reason for hiding this comment

Uh oh!

MayNiklas Mar 14, 2026

Choose a reason for hiding this comment

Uh oh!

MayNiklas Mar 14, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

whinis commented Mar 13, 2026 •

edited

Loading